Comments on: Clever Digital I/O handling in C http://www.youritronics.com/clever-digital-io-handling-in-c/ DIY, Electronics, IT, Gadgets Sat, 28 Jan 2012 20:46:04 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Laci http://www.youritronics.com/clever-digital-io-handling-in-c/comment-page-1/#comment-6151 Laci Mon, 16 Mar 2009 11:18:17 +0000 http://www.youritronics.com/?p=1852#comment-6151 I personally don't like to paranthizes everything, since "a" will be always a register or variable name, and "p" a number it will work just fine. Its everybody's personal choice or coding style how many paranthizes uses above the minimum required. I personally don’t like to paranthizes everything, since “a” will be always a register or variable name, and “p” a number it will work just fine. Its everybody’s personal choice or coding style how many paranthizes uses above the minimum required.

]]> By: Marvin http://www.youritronics.com/clever-digital-io-handling-in-c/comment-page-1/#comment-6127 Marvin Wed, 11 Mar 2009 09:50:49 +0000 http://www.youritronics.com/?p=1852#comment-6127 Please be aware, that you should fully parenthizes all macro arguments and the macro itself. The correct macro definition would therefore be: #define IS_BIT(a,p) ((a) & (1 << (p))) // test the a variable p bit #define SET_BIT(a,p) ((a) |= 1 << (p)) // set in a the p bit #define CLR_BIT(a,p) ((a) &= ~(1 << (p))) // clear in a the p bit Please be aware, that you should fully parenthizes all macro arguments and the macro itself. The correct macro definition would therefore be:

#define IS_BIT(a,p) ((a) & (1 << (p))) // test the a variable p bit
#define SET_BIT(a,p) ((a) |= 1 << (p)) // set in a the p bit
#define CLR_BIT(a,p) ((a) &= ~(1 << (p))) // clear in a the p bit

]]>